implement php 8.4 http_get_last_response_headers and http_clear_last_response_headers - #4
Conversation
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Team Run ID: Comment |
|
Thanks for the PR @vapebw. It looks good but you need to add actual HTTP regression tests. We should verify headers after |
I think its done now, regression tests are working i will appreciate review :) |
|
@vapebw Can you fix conflicts |
yeah i forgot to fix conflicts sorry |
1259cc0 to
63fe8b9
Compare
Implemented PHP 8.4
http_get_last_response_headers()andhttp_clear_last_response_headers().Changes
src/runtime/vm.zig: Addedlast_http_response_headers: ?*PhpArray = nulltoVMstruct and reset it inVM.reset().src/stdlib/http.zig: Implementedhttp_get_last_response_headers()andhttp_clear_last_response_headers()inentries.src/stdlib/native_params.zig: Registered 0-arg parameter signatures for named arguments.src/stdlib/filesystem.zig: AddedCURLOPT_HEADERFUNCTIONinfetchUrl()to capture response headers intolast_http_response_headerson HTTP requests, and reset state on request entry.tests/php84_http_response_headers.php: Added regression tests for function existence, return types, repeated clears, and reflection metadata.